Add CachingLocator. - #14020
Merged
Eric Snow (ericsnowcurrently) merged 39 commits intoOct 8, 2020
Merged
Conversation
Eric Snow (ericsnowcurrently)
requested review from
Kartik Raj (karrtikr) and
Kim-Adeline Miguel (kimadeline)
September 21, 2020 22:52
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
September 21, 2020 23:17
390f221 to
48445b7
Compare
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
September 23, 2020 03:33
48445b7 to
85b2b6b
Compare
4 tasks
10 tasks
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
September 29, 2020 00:23
85b2b6b to
e41ccef
Compare
Codecov Report
@@ Coverage Diff @@
## main #14020 +/- ##
==========================================
+ Coverage 59.96% 60.04% +0.07%
==========================================
Files 706 710 +4
Lines 39180 39420 +240
Branches 5681 5708 +27
==========================================
+ Hits 23494 23668 +174
- Misses 14449 14501 +52
- Partials 1237 1251 +14
Continue to review full report at Codecov.
|
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
September 29, 2020 02:01
e41ccef to
5fabd2a
Compare
Eric Snow (ericsnowcurrently)
marked this pull request as ready for review
September 29, 2020 02:01
Author
|
Kim-Adeline Miguel (@kimadeline) and Kartik Raj (@karrtikr), I should have left this as a draft PR. I'll let you know when I've wrapped up the last few changes I have to make. |
Eric Snow (ericsnowcurrently)
marked this pull request as draft
September 29, 2020 15:41
10 tasks
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
September 30, 2020 21:05
5fabd2a to
0d8f49d
Compare
Eric Snow (ericsnowcurrently)
marked this pull request as ready for review
September 30, 2020 22:25
Eric Snow (ericsnowcurrently)
requested review from
Kartik Raj (karrtikr) and
Kim-Adeline Miguel (kimadeline)
September 30, 2020 22:33
Author
|
Kim-Adeline Miguel (@kimadeline), Kartik Raj (@karrtikr), the PR is ready to go now. |
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
September 30, 2020 22:40
0d8f49d to
9e97735
Compare
Kim-Adeline Miguel (kimadeline)
suggested changes
Oct 1, 2020
|
Since Kartik is out, you may want to request a review from Karthik Nadig (@karthiknadig), because I don't want to shoulder the responsibility of reviewing this PR alone 😆 |
|
Eric Snow (@ericsnowcurrently) Kim-Adeline Miguel (@kimadeline) I just had one comment regarding potential correctness #14020 (comment) I leave the rest upto you guys😄 |
Kartik Raj (karrtikr)
removed their request for review
October 1, 2020 19:29
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
October 5, 2020 20:31
9e97735 to
4cc412e
Compare
Eric Snow (ericsnowcurrently)
requested a review
from Karthik Nadig (karthiknadig)
October 5, 2020 20:32
Eric Snow (ericsnowcurrently)
force-pushed
the
pyenvs-component-caching-locator
branch
from
October 7, 2020 18:54
abf86c3 to
e8914f6
Compare
Eric Snow (ericsnowcurrently)
requested review from
Karthik Nadig (karthiknadig) and
Kim-Adeline Miguel (kimadeline)
October 7, 2020 18:58
|
Will re-review this afternoon. |
Kim-Adeline Miguel (kimadeline)
approved these changes
Oct 7, 2020
Karthik Nadig (karthiknadig)
approved these changes
Oct 7, 2020
Author
|
resetting "checks" trigger |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #14020 +/- ##
==========================================
- Coverage 59.91% 59.91% -0.01%
==========================================
Files 709 712 +3
Lines 39334 39520 +186
Branches 5698 5722 +24
==========================================
+ Hits 23567 23678 +111
- Misses 14529 14586 +57
- Partials 1238 1256 +18
Continue to review full report at Codecov.
|
Eric Snow (ericsnowcurrently)
deleted the
pyenvs-component-caching-locator
branch
October 8, 2020 19:54
Luciana Abud (luabud)
pushed a commit
to luabud/vscode-python
that referenced
this pull request
Oct 26, 2020
Note that we factored out the BackgroundRequestLooper class to keep CachingLocator focused, especially as it was important to deal with one "refresh" at a time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that I factored out the
BackgroundRequestLooperclass to keepCachingLocatorfocused, especially as I found it was important to deal with one "refresh" at a time.[ ] Has a news entry file (remember to thank yourself!).[ ] Has telemetry for enhancements.[ ] Test plan is updated as appropriate.[ ]package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).[ ] The wiki is updated with any design decisions/details.